Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterize mc image and fix access_key/secret_key #2619

Merged
merged 5 commits into from
Nov 6, 2020

Conversation

omerfsen
Copy link
Contributor

@omerfsen omerfsen commented Nov 6, 2020

If we don't pass this --api S3v4 we are getting

The request signature we calculated does not match the signature you provided. Check your key and signing method

error

minio/minio#7936

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

If we don't pass this --api S3v4 we are getting 

```The request signature we calculated does not match the signature you provided. Check your key and signing method``` 

error 

minio/minio#7936
@seldondev
Copy link
Collaborator

Hi @omerfsen. Thanks for your PR.

I'm waiting for a SeldonIO member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@seldondev seldondev added size/S and removed size/XS labels Nov 6, 2020
@omerfsen omerfsen changed the title Add --api S3v4 to mc client Parameterize mc image and fix access_key/secret_key Nov 6, 2020
@axsaucedo
Copy link
Contributor

THank you @omerfsen - looks good
/ok-to-test
/approve

@axsaucedo axsaucedo merged commit 5348601 into SeldonIO:master Nov 6, 2020
@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Fri Nov 6 14:57:39 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2619/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2619 --build=1

@seldondev
Copy link
Collaborator

Fri Nov 6 14:57:46 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2619/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2619 --build=2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants