Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use UTF-8 code for check mark #2627

Merged
merged 1 commit into from
Nov 12, 2020
Merged

Conversation

adriangonz
Copy link
Contributor

What this PR does / why we need it:

Sphinx doesn't support "emoji codes" like Markdown does. Thus, they get rendered in the docs as:

image

This PR changes that :heavy_check_mark: into the equivalent UTF-8 code (i.e. ✅).

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign adriangonz
You can assign the PR to them by writing /assign @adriangonz in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Wed Nov 11 16:30:01 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2627/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2627 --build=1

@seldondev
Copy link
Collaborator

Wed Nov 11 16:30:03 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2627/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2627 --build=2

@axsaucedo axsaucedo merged commit 58c399a into SeldonIO:master Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants