Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --no-cache-dir inside s2i wrappers #2725

Merged
merged 1 commit into from
Dec 1, 2020

Conversation

MuhammadAgf
Copy link
Contributor

What this PR does / why we need it:
add --no-cache-dir to remove pip cache

Which issue(s) this PR fixes:

Fixes #2581

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@seldondev
Copy link
Collaborator

Hi @m46f. Thanks for your PR.

I'm waiting for a SeldonIO member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@MuhammadAgf
Copy link
Contributor Author

/assign @axsaucedo

@axsaucedo
Copy link
Contributor

Great, thanks @m46f
/ok-to-test
/test integration

@axsaucedo
Copy link
Contributor

/approve

@axsaucedo axsaucedo added this to In progress in 1.6.0 via automation Dec 1, 2020
@axsaucedo axsaucedo added this to the 1.6 milestone Dec 1, 2020
@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Tue Dec 1 18:18:30 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2725/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2725 --build=1

@seldondev
Copy link
Collaborator

Tue Dec 1 18:18:36 UTC 2020
The logs for [integration] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2725/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2725 --build=2

@seldondev
Copy link
Collaborator

Tue Dec 1 18:18:40 UTC 2020
The logs for [lint] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2725/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2725 --build=3

@seldondev
Copy link
Collaborator

Tue Dec 1 20:11:53 UTC 2020
The logs for [lint] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2725/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2725 --build=5

@seldondev
Copy link
Collaborator

Tue Dec 1 20:12:07 UTC 2020
The logs for [pr-build] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2725/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2725 --build=4

@seldondev seldondev merged commit 4b3ae0c into SeldonIO:master Dec 1, 2020
1.6.0 automation moved this from In progress to Done Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
1.6.0
Done
Development

Successfully merging this pull request may close these issues.

Pip cache removal in wrappers/s2i/python/s2i/bin/assemble
3 participants