Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend init containers documentation #2814

Merged
merged 2 commits into from
Jan 11, 2021

Conversation

RafalSkolasinski
Copy link
Contributor

@RafalSkolasinski RafalSkolasinski commented Jan 5, 2021

What this PR does / why we need it:

Initial documentation of Init Containers used for prepackaged model servers that dives into technical requirements that custom init container would need to satisfy.

Which issue(s) this PR fixes:

Closes #2055
Closes #2818

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@seldondev
Copy link
Collaborator

Tue Jan 5 21:49:51 UTC 2021
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2814/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2814 --build=1

@seldondev
Copy link
Collaborator

Tue Jan 5 21:50:05 UTC 2021
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2814/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2814 --build=2

@seldondev
Copy link
Collaborator

Tue Jan 5 21:52:01 UTC 2021
The logs for [lint] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2814/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2814 --build=4

@seldondev
Copy link
Collaborator

Tue Jan 5 21:52:10 UTC 2021
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2814/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2814 --build=3

@seldondev
Copy link
Collaborator

Tue Jan 5 21:54:59 UTC 2021
The logs for [pr-build] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2814/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2814 --build=5

@seldondev
Copy link
Collaborator

Tue Jan 5 21:55:17 UTC 2021
The logs for [lint] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2814/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2814 --build=6

@axsaucedo axsaucedo added this to Backlog in Backlog Jan 7, 2021
@axsaucedo axsaucedo removed this from Backlog in Backlog Jan 7, 2021
@seldondev seldondev added size/XL and removed size/M labels Jan 7, 2021
@seldondev
Copy link
Collaborator

Thu Jan 7 18:56:52 UTC 2021
The logs for [pr-build] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2814/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2814 --build=7

@seldondev
Copy link
Collaborator

Thu Jan 7 18:57:04 UTC 2021
The logs for [lint] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2814/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2814 --build=8

@axsaucedo
Copy link
Contributor

/approve

@axsaucedo
Copy link
Contributor

/approve

@seldondev seldondev added the lgtm label Jan 11, 2021
@axsaucedo axsaucedo merged commit c9fe796 into SeldonIO:master Jan 11, 2021
@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add example of custom init container with rclone Add documentation that dives into the iniContainer
3 participants