Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow feedback for routers and update router examples #2865

Merged
merged 1 commit into from
Jan 26, 2021
Merged

Allow feedback for routers and update router examples #2865

merged 1 commit into from
Jan 26, 2021

Conversation

ukclivecox
Copy link
Contributor

What this PR does / why we need it:

  • Ensure Feedback is sent to Routers
  • Adds a notebook for epsilon greedy router
  • Updates routers case study

Which issue(s) this PR fixes:

Fixes #2827

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@seldondev
Copy link
Collaborator

Thu Jan 21 18:28:33 UTC 2021
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2865/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2865 --build=2

@seldondev
Copy link
Collaborator

Thu Jan 21 18:28:42 UTC 2021
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2865/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2865 --build=1

@axsaucedo
Copy link
Contributor

Looks good!
/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Tue Jan 26 13:26:04 UTC 2021
The logs for [lint] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2865/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2865 --build=4

@seldondev
Copy link
Collaborator

Tue Jan 26 13:26:25 UTC 2021
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2865/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2865 --build=3

@seldondev seldondev merged commit ce93dd9 into SeldonIO:master Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Executor does not send feedback to Routers.
3 participants