Executor does not send feedback to Routers.

[ukclivecox]

https://github.com/SeldonIO/seldon-core/blob/master/executor/predictor/predictor_process.go#L135

[axsaucedo]

In this case it would skip calling the ROUTER component in favour of getting it from the meta (

seldon-core/executor/predictor/predictor_process.go

Line 247 in 23d7dc5

route, err := p.routeFeedback(node, msg)

), and then it would just call the MODEL components via send_feedback instead of predict, so it should still pass the feedback to the router MODEL nodes.

Do you mean that currently it's not passing the data to the MODEL components?

[ukclivecox]

For MABs there is logic in send-feedback to update state so I think it should send feedback to routers.

[axsaucedo]

Oh I see what you mean, so basically it shouldn't call the "route" method, but it should still call the send_feedback method. Ok I can see that the MAB router also has a send_feedback logic, so it would make sense. It seems that also adding the v1.SEND_FEEDBACK method in:

seldon-core/executor/predictor/predictor_process.go

Line 139 in 23d7dc5

if hasMethod(v1.SEND_FEEDBACK, node.Methods) {

It seems that the predictor bean also has similar logic:

seldon-core/engine/src/main/java/io/seldon/engine/predictors/PredictiveUnitBean.java

Line 300 in 23d7dc5

if (predictorConfig.hasMethod(PredictiveUnitMethod.SEND_FEEDBACK, state)) {

I'm not as familiar with the java side, so just to confirm, is this assumption correct?

I do agree that it would make sense to also ensure the send_feedback is passed to the router element, as it could help update its current state. Do you think it should be done explicitly by providing the method in the CRD, or by default?

[ukclivecox]

Yes. That makes sense. The logic is in the engine but missing from the executor.