Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Python Builder to use latest git for compatibility with github actions #2894

Merged
merged 2 commits into from
Jan 27, 2021

Conversation

axsaucedo
Copy link
Contributor

Currently the Python lint test is failing due to old version of git being used (2.11) as per actions/checkout#126

This PR upgrades the version of git, which is ultimately required in the python lint job as it performs a diff with master.

@axsaucedo axsaucedo added this to In progress in Sprint 2 via automation Jan 27, 2021
@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign axsaucedo
You can assign the PR to them by writing /assign @axsaucedo in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@axsaucedo
Copy link
Contributor Author

@RafalSkolasinski are there any further changes required?

@RafalSkolasinski
Copy link
Contributor

As long as this fixes the problem it looks all good and reasonable to me

Copy link
Contributor

@RafalSkolasinski RafalSkolasinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sprint 2 automation moved this from In progress to Reviewer approved Jan 27, 2021
@axsaucedo axsaucedo merged commit 2e5748a into SeldonIO:master Jan 27, 2021
Sprint 2 automation moved this from Reviewer approved to Done Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants