Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Python Builder to use latest git for compatibility with github actions #2894

Merged
merged 2 commits into from
Jan 27, 2021
Merged

Update Python Builder to use latest git for compatibility with github actions #2894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a18b53e
Added new python builder with latest git
axsaucedo Jan 27, 2021
4a33709
Running action with latest python
axsaucedo Jan 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/python_lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
python-lint:

runs-on: ubuntu-18.04
container: seldonio/python-builder:0.2
container: seldonio/python-builder:0.3

steps:
- uses: actions/checkout@v2
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/python_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
python-tests:

runs-on: ubuntu-18.04
container: seldonio/python-builder:0.2
container: seldonio/python-builder:0.3

steps:
- uses: actions/checkout@v2
Expand Down
10 changes: 10 additions & 0 deletions python-builder/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,16 @@ RUN pip install flatbuffers
RUN pip install twine
RUN pip install mypy-protobuf

# Install latest git
RUN apt-get upgrade -y
RUN apt-get update -y
RUN apt-get install -y make libssl-dev libghc-zlib-dev libcurl4-gnutls-dev libexpat1-dev gettext unzip
RUN wget https://github.com/git/git/archive/v2.30.0.zip -O git.zip
RUN unzip git.zip
RUN apt-get remove git -y
RUN make prefix=/usr/local -C git-2.30.0/ all install


WORKDIR /work

# Define default command.
Expand Down
2 changes: 1 addition & 1 deletion python-builder/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
DOCKER_IMAGE_NAME=seldonio/python-builder
DOCKER_IMAGE_VERSION=0.2
DOCKER_IMAGE_VERSION=0.3

build_docker_image:
docker build --force-rm=true -t $(DOCKER_IMAGE_NAME):$(DOCKER_IMAGE_VERSION) .
Expand Down