Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iter8 Integration #3286

Merged
merged 7 commits into from
Jun 15, 2021
Merged

Iter8 Integration #3286

merged 7 commits into from
Jun 15, 2021

Conversation

ukclivecox
Copy link
Contributor

What this PR does / why we need it:

Allow AB and Progressive Rollouts

Which issue(s) this PR fixes:

Fixes #3278

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign cliveseldon
You can assign the PR to them by writing /assign @cliveseldon in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@axsaucedo
Copy link
Contributor

/test integration

@axsaucedo
Copy link
Contributor

/test notebooks

@ukclivecox ukclivecox changed the title WIP: Iter8 Integration Iter8 Integration Jun 15, 2021
@axsaucedo
Copy link
Contributor

/test integration

@axsaucedo
Copy link
Contributor

/test notebooks

@axsaucedo
Copy link
Contributor

Really cool - PR looks good and all e2e tests pass so should be good to merge, only thing is that docs tests are failing

@axsaucedo
Copy link
Contributor

Merging as docs test seems to be failing in master so can fix in separate pr

@axsaucedo axsaucedo merged commit 52d8a28 into SeldonIO:master Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate Iter8
3 participants