Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use FQDN in the host field of Istio resources #4408

Merged
merged 1 commit into from Feb 17, 2023

Conversation

ysk24ok
Copy link
Contributor

@ysk24ok ysk24ok commented Oct 28, 2022

What this PR does / why we need it:

This PR enables the Istio VirtualService and DestinationRule to use FQDN in the host field, as Istio recommends doing so.

To avoid potential misconfiguration, it is recommended to always use fully qualified domain names over short names

Which issue(s) this PR fixes:

Fixes #4387

Special notes for your reviewer:

@seldondev
Copy link
Collaborator

Hi @ysk24ok. Thanks for your PR.

I'm waiting for a SeldonIO or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign gsunner
You can assign the PR to them by writing /assign @gsunner in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ukclivecox
Copy link
Contributor

/test integration

@ukclivecox
Copy link
Contributor

/test notebooks

@ukclivecox ukclivecox self-assigned this Dec 9, 2022
@ukclivecox ukclivecox added the v1 label Dec 27, 2022
Copy link
Contributor

@adriangonz adriangonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ysk24ok ,

Apologies for the long delay to review this one.

Just had a look and changes look good! Integration tests seem to pass, so this should be ready to go.

Thanks a lot for your contribution! 🚀

@adriangonz adriangonz merged commit 8d0d70e into SeldonIO:master Feb 17, 2023
@ysk24ok ysk24ok deleted the use_fqdn branch July 6, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to use an FQDN in a host of Istio VirtualService Destination field
4 participants