Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use constant from constants package #4672

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

adriangonz
Copy link
Contributor

What this PR does / why we need it:
Follow up to #4408 to ensure we use the constant from the constants package instead of (a new) hardcoded string.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@adriangonz
Copy link
Contributor Author

/test integration

@adriangonz
Copy link
Contributor Author

/test notebooks

@adriangonz adriangonz merged commit 61a5a91 into SeldonIO:master Feb 17, 2023
@adriangonz adriangonz deleted the use-constants branch February 17, 2023 16:25
@seldondev
Copy link
Collaborator

@adriangonz: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
notebooks 6bb4862 link /test notebooks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants