Seldon Core V2 Go 3rd party licenses #4520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakoush
approved these changes
Dec 21, 2022
There was a problem hiding this comment.
LGTM
Given that the target is repeated across several makefiles could we instead have one place where the logic is defined and then have a list of directories to operate on? I understand the urgency so it can be a follow up PR perhaps if it is not straightforward
|
Also any potentially not friendly licences discovered? |
|
No. There are four LGPL projects but with added exceptions that allow for static and dynamic linking, e.g. here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Go 3rd party license tooling and current set of licenses.