v2: Remove need for ONESHELL in go lint

[ukclivecox]

Removes the need to use the ONESHELL directive in Makefiles for Go lint download. ONESHELL is a global directive for the entire Makefile and causes issues in getting the go license updates to run as it stops normal error failure during Makefile runs, i.e. an error code from a command should stop the Make run.

From docs:

Even with this special feature, however, makefiles with .ONESHELL will behave differently in ways that could be noticeable. For example, normally if any line in the recipe fails, that causes the rule to fail and no more recipe lines are processed. Under .ONESHELL a failure of any but the final recipe line will not be noticed by make. You can modify .SHELLFLAGS to add the -e option to the shell which will cause any failure anywhere in the command line to cause the shell to fail, but this could itself cause your recipe to behave differently. Ultimately you may need to harden your recipe lines to allow them to work with .ONESHELL.

[sakoush]

Are we always installing go lint every time now? If so how long does it usually take?

[ukclivecox]

We are not. It should only install if its not there.

[sakoush]

It is not clear to me how this is done given that we are removing the logic to check if the location of golint exist?

[ukclivecox]

${.GOLANGCILINT_PATH}/golangci-lint: should only run if needed.

[sakoush]

LGTM