Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add app-vulns flag to Python images #4608

Merged
merged 4 commits into from
Jan 30, 2023

Conversation

adriangonz
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #4605

Special notes for your reviewer:

Copy link
Contributor

@RafalSkolasinski RafalSkolasinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! Shall we have the same for V2 scans?

@adriangonz
Copy link
Contributor Author

Yeah, definitely.

Should we also enable it for the Go images (for both V1 and V2), even though the code is also scanned separately?

@adriangonz
Copy link
Contributor Author

Waiting on #4612 to get merged

@ukclivecox ukclivecox added the v1 label Jan 28, 2023
@adriangonz adriangonz merged commit ee44006 into SeldonIO:master Jan 30, 2023
@adriangonz adriangonz deleted the app-vulns-python branch January 30, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add app-vulns flag to Snyk scans
3 participants