Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CVEs for Alibi images #4612

Merged
merged 21 commits into from
Jan 30, 2023
Merged

Conversation

adriangonz
Copy link
Contributor

What this PR does / why we need it:
Fix a couple CVEs related to Tensorflow, PyJWT and RClone in the explainer and detector images for SC V1.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@adriangonz
Copy link
Contributor Author

This should be good to go now. It needed a couple more changes on imports, as well as the test pipelines, and a test artefact.

If you are happy with the latest changes @cliveseldon @RafalSkolasinski, we can go ahead with this one.

@RafalSkolasinski
Copy link
Contributor

What about integration/notebook tests?

@adriangonz
Copy link
Contributor Author

/test integration

@adriangonz
Copy link
Contributor Author

/test notebooks

@adriangonz
Copy link
Contributor Author

/test integration

@adriangonz
Copy link
Contributor Author

/test notebook

@adriangonz
Copy link
Contributor Author

/test notebooks

@adriangonz
Copy link
Contributor Author

/test integration

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@adriangonz
Copy link
Contributor Author

/test integration

@adriangonz
Copy link
Contributor Author

/test notebooks

@adriangonz
Copy link
Contributor Author

Both integration and notebook tests seem to pass now! The docs lint issue should be addressed in master already.

image

Copy link
Contributor

@RafalSkolasinski RafalSkolasinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@adriangonz adriangonz merged commit 24467f0 into SeldonIO:master Jan 30, 2023
adriangonz pushed a commit that referenced this pull request Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants