-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make ambassador a dependency #480
Changes from all commits
e696eac
39117b6
b0feaf9
71b0cfb
9e545dd
f3f558d
b31c0e3
656ac5b
6c7857f
7c40899
fc2957a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -273,7 +273,8 @@ | |
"source": [ | ||
"!helm install ../../../helm-charts/seldon-core --name seldon-core \\\n", | ||
" --namespace seldon \\\n", | ||
" --set ambassador.enabled=true" | ||
" --set ambassador.enabled=true \\\n", | ||
" --set ambassador.env.AMBASSADOR_SINGLE_NAMESPACE=true" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this is not strictly necessary as otherwise it will be cluster-wide and that would work too. But previously it was namespace-only. In addition to running the tests I also stepped through this notebook to make sure it was ok to make this change. I was able to make all the requests. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For a little while I wasn't able to see anything in the grafana dashboard but that turned out to be unrelated as I was seeing it with master too and it was fixed by recreating minikube. |
||
] | ||
}, | ||
{ | ||
|
@@ -367,7 +368,7 @@ | |
"metadata": {}, | ||
"source": [ | ||
"```\n", | ||
"kubectl port-forward $(kubectl get pods -n seldon -l service=ambassador -o jsonpath='{.items[0].metadata.name}') -n seldon 8003:8080\n", | ||
"kubectl port-forward $(kubectl get pods -n seldon -l app.kubernetes.io/name=ambassador -o jsonpath='{.items[0].metadata.name}') -n seldon 8003:8080\n", | ||
"```" | ||
] | ||
}, | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
dependencies: | ||
- name: ambassador | ||
version: ^2.0.1 | ||
repository: https://kubernetes-charts.storage.googleapis.com/ | ||
condition: ambassador.enabled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed these were generated so put in gitignore and also the clean script in the testing makefile