Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use release namespace for configmaps in setup helm chart #4832

Merged
merged 1 commit into from
May 13, 2023

Conversation

rajatvig
Copy link

@rajatvig rajatvig commented May 6, 2023

What this PR does / why we need it:

Adds the release namespace for the agent, kafka, and tracing configmaps and for rclone secret.

Which issue(s) this PR fixes:
None

Set the namespace for Agent, Kafka and Tracing `ConfigMap` and for the `rclone` `Secret`.

Special notes for your reviewer:
None

Signed-off-by: Rajat Vig <rvig@etsy.com>
@seldondev
Copy link
Collaborator

Hi @rajatvig. Thanks for your PR.

I'm waiting for a SeldonIO or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@ukclivecox ukclivecox added the v2 label May 10, 2023
@rajatvig
Copy link
Author

Could this be merged? I see the approval but I do not have rights to merge it

@RafalSkolasinski RafalSkolasinski merged commit 7b8880f into SeldonIO:v2 May 13, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants