Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow digits in topic prefix #5051

Merged
merged 1 commit into from
Jul 21, 2023
Merged

fix: Allow digits in topic prefix #5051

merged 1 commit into from
Jul 21, 2023

Conversation

ukclivecox
Copy link
Contributor

Adds missing digits to regexp checking topic prefix.

Fixes #5050

@ukclivecox ukclivecox added the v2 label Jul 21, 2023
@ukclivecox ukclivecox requested a review from agrski July 21, 2023 16:34
@ukclivecox ukclivecox changed the title Allow digits in topic prefix fix: Allow digits in topic prefix Jul 21, 2023
Copy link
Contributor

@agrski agrski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is consistent with the Kafka definition, at least in a previous version

@ukclivecox ukclivecox merged commit b400ae3 into SeldonIO:v2 Jul 21, 2023
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants