build(dataflow): bump grpc-stub and grpc-protobuf to 1.57.2 #5110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriangonz
changed the title
|
On top of the CI tests, I've also done some manual integration tests with our sample notebooks and all seems good 👍 |
agrski
approved these changes
Aug 29, 2023
There was a problem hiding this comment.
From my side, I've just checked the following:
make -C scheduler build-jvm
./gradlew build --refresh-dependencies
./gradlew testand all these ran without issue. I'm not expecting any major issues from these dependencies being updated, so as long as the dataflow engine can connect to the scheduler, this all seems fine to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Address CVE-2023-2976
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: