fix(scheduler): Fix deleting models that are still progressing #5143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakoush
changed the title
ukclivecox
reviewed
Oct 2, 2023
k8s/yaml/dcgm-on-gke/LICENSE
Outdated
| @@ -0,0 +1,201 @@ | |||
| Apache License | |||
There was a problem hiding this comment.
Why is this file been added?
There was a problem hiding this comment.
this was a commit from a stale branch, remove now in
ukclivecox
reviewed
Oct 2, 2023
| @@ -0,0 +1,147 @@ | |||
| # Copyright 2022 Google LLC | |||
| # | |||
ukclivecox
reviewed
Oct 2, 2023
k8s/yaml/dcgm.yaml
Outdated
| @@ -0,0 +1,78 @@ | |||
| apiVersion: apps/v1 | |||
| kind: DaemonSet | |||
| metadata: | |||
ukclivecox
approved these changes
Oct 2, 2023
RafalSkolasinski
pushed a commit
that referenced
this pull request
Jan 22, 2024
* remove check that the model is deleted * send events downstream with unloaded * update status * lock model before updating status * lint * lint (operator)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This changes allows deleting models that are still progressing when we delete the associated server. Previously the model state gets stuck.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: