Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(envoy): add readiness probe to Envoy #5158

Merged
merged 1 commit into from Nov 2, 2023
Merged

fix(envoy): add readiness probe to Envoy #5158

merged 1 commit into from Nov 2, 2023

Conversation

SDJustus
Copy link

@SDJustus SDJustus commented Nov 2, 2023

What this PR does / why we need it:
this PR adds a readiness prove to envoy to prevent it from getting traffic while not being able to handle the requests. Primarily this is needed, if the pod starts/restarts.
Which issue(s) this PR fixes:

Fixes #5157

Special notes for your reviewer:
I was first thinking about adding a startup probe for this, but the kubernetes docs state, that this is mostly done for slow starting services and I don't think the envoy is one. On my cluster, the envoy restart/start takes between 10 and 15 seconds so the initial delay of 10 seconds and 3 retries every 5 seconds should be sufficient.
I couldn't see any problems with controller after the health check was added.

@seldondev
Copy link
Collaborator

Hi @SDJustus. Thanks for your PR.

I'm waiting for a SeldonIO or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@agrski agrski self-requested a review November 2, 2023 13:52
@agrski agrski added the v2 label Nov 2, 2023
@SDJustus SDJustus changed the title added readiness probe to envoy; fixes #5157 fix(envoy): added readiness probe to envoy; fixes #5157 Nov 2, 2023
Copy link
Contributor

@agrski agrski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done two things to test this, having checked out the PR:

  • I've tried running make -C operator create and confirmed there are no changes.
  • I've tried installing the updated chart into an existing kind cluster, confirmed the probe is now set, and confirmed that k8s doesn't mark the pod as ready instantly. In fact, when port-forwarding the admin port I was able to hit the /ready endpoint before it was ready and confirmed the statuses being sent then and after readiness (503 and 200 respectively).

@agrski agrski changed the title fix(envoy): added readiness probe to envoy; fixes #5157 fix(envoy): add readiness probe to Envoy Nov 2, 2023
@agrski agrski merged commit d350206 into SeldonIO:v2 Nov 2, 2023
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants