fix(gateway): wait for kafka topic creation #5359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lc525
changed the title
sakoush
reviewed
Feb 26, 2024
sakoush
reviewed
Feb 26, 2024
lc525
commented
Feb 26, 2024
| @@ -241,7 +287,7 @@ func (kc *InferKafkaHandler) AddModel(modelName string) error { | |||
| kc.subscribedTopics[inputTopic] = true | |||
| err := kc.subscribeTopics() | |||
| if err != nil { | |||
| kc.logger.WithError(err).Warn("Failed to subscribe to topics") | |||
| kc.logger.WithError(err).Errorf("failed to subscribe to topics") | |||
| return nil | |||
There was a problem hiding this comment.
we should investigate more on why all of these errors are being swallowed in infer.go instead of being returned
Kafka topic creation happens asynchronously. This means that even when the return value from createTopics(...) indicates that the topic has been created successfuly, the topic can not be immediately subscribed to. We retry DescribeTopics until all of the topics for the pipeline can be described successfully. This indicates that the topic has been fully created at least on one broker, and can now be subscribed to. Which issue(s) this PR fixes: Fixes gateway component for #INFRA-663 (internal): Pipeline creation goes into ERROR state
- timeout config now in gateway/constants.go - reversal of the `pipeline.wg.Add(1)` code move - adding error returns when reaching error states - tidying-up of error reporting
lc525
force-pushed
the
fix.gateway.kafka-wait-for-topic-creation
branch
from
ea3101d
to
79fc658
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Kafka topic creation happens asynchronously. This means that even when the
return value from createTopics(...) indicates that the topic has been created
successfuly, the topic can not be immediately subscribed to.
We retry DescribeTopics until all of the topics for the pipeline can be
described successfully. This indicates that the topic has been fully created at
least on one broker, and can now be subscribed to.
Which issue(s) this PR fixes:
Fixes gateway component for #INFRA-663 (internal): Pipeline creation goes into ERROR state