Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gateway): wait for kafka topic creation #5359

Merged
merged 7 commits into from
Feb 27, 2024

Commits on Feb 26, 2024

  1. fix(gateway) wait for kafka topic creation

    Kafka topic creation happens asynchronously. This means that even when the
    return value from createTopics(...) indicates that the topic has been created
    successfuly, the topic can not be immediately subscribed to.
    
    We retry DescribeTopics until all of the topics for the pipeline can be
    described successfully. This indicates that the topic has been fully created at
    least on one broker, and can now be subscribed to.
    
    Which issue(s) this PR fixes:
    Fixes gateway component for #INFRA-663 (internal): Pipeline creation goes into ERROR state
    lc525 committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    2fb7a69 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    335b718 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5917862 View commit details
    Browse the repository at this point in the history
  4. fix(gateway): move timeout config to constants file, PR comments

    - timeout config now in gateway/constants.go
    - reversal of the `pipeline.wg.Add(1)` code move
    - adding error returns when reaching error states
    - tidying-up of error reporting
    lc525 committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    3d584ed View commit details
    Browse the repository at this point in the history
  5. fix(gateway) whitespace fix

    lc525 committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    04fa1a5 View commit details
    Browse the repository at this point in the history
  6. cleanup imports & error message

    lc525 committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    0f100a7 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2024

  1. fix lints

    lc525 committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    79fc658 View commit details
    Browse the repository at this point in the history