Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dataflow): be more strict about error states on pipeline creation #5381

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

lc525
Copy link
Member

@lc525 lc525 commented Feb 28, 2024

Only return success = true if the pipeline is running

A concurrency issue remains because if running the code on multiple coroutines these may interleave at suspension points. This is not an issue atm, as we are executing on one coroutine. If/when we introduce more parallelism, this will need to be dealt with.

Fixed issues:

  • #INFRA-830 (internal): pipeline might be marked ready before is actually running

- only return success = true if the pipeline is running

A concurrency issue remains because if running the code on multiple coroutines
these may interleave at suspension points. This is not an issue atm, as we are
executing on one coroutine. If/when we introduce more parallelism, this will
need to be dealt with.

**Fixed issues**:
- #INFRA-830 (internal): pipeline might be marked ready before is actually running
@lc525 lc525 requested a review from sakoush as a code owner February 28, 2024 10:04
@lc525 lc525 added the v2 label Feb 28, 2024
Copy link
Member

@sakoush sakoush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. although we probably need to test if the state on the scheduler side can be moved to ready (once it has started) beyond this point.

For now as we are effectively running serial operations this case cannot happen.

@lc525 lc525 merged commit 95d044b into SeldonIO:v2 Feb 29, 2024
3 of 4 checks passed
@lc525 lc525 deleted the hotfix.2.8.0-rc2.dataflow.pipeline-ready branch February 29, 2024 10:47
@seldondev
Copy link
Collaborator

failed to trigger Pull Request pipeline

  • failed to create agent
  • failed to calculate in repo config
  • failed to load trigger config for repository SeldonIO/seldon-core for ref
  • failed to switch to ref
  • failed to merge repository SeldonIO/seldon-core
  • failed to run command in dir /var/tmp/gitrepo3773906085
  • git, [merge FETCH_HEAD]
  • Updating cfe54e2..6a45b2b
    error
  • Your local changes to the following files would be overwritten by merge:
    .github/workflows/images.yml
    Please commit your changes or stash them before you merge.
    Aborting
  • exit status 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants