fix(scheduler): Increase event hub buffer inline with other components #5406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lc525
approved these changes
Mar 7, 2024
| @@ -588,6 +588,7 @@ func (p *IncrementalProcessor) modelUpdate(modelName string) error { | |||
| logger.Debugf("sync: No server - removing for %s", modelName) | |||
| if err := p.removeRouteForServerInEnvoyCache(modelName); err != nil { | |||
| logger.WithError(err).Errorf("Failed to remove model route from envoy %s", modelName) | |||
| p.modelStore.UnlockModel(modelName) | |||
There was a problem hiding this comment.
we might be able to convert this into a defer, as we always unlock before return
There was a problem hiding this comment.
It looks like we need to release the model lock before running further logic at the end of this method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This change increases the pending queues in the event hub (coordinator) for server and model events delivery. There is going to be a tradeoff, with a bigger buffer we allow more work to pile up if the producer is faster than the consumer. However in practice setting it to
1000has worked fined in other cases, check here.It also reduces the risk of deadlocks as producers will block otherwise when trying to publish on a queue that it full.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: