Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: support multi shadow #5610

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ooooona
Copy link
Contributor

@ooooona ooooona commented May 20, 2024

Background: For Istio with version >= 1.20 has supported multi mirrors, while seldon cannot work even if we tried to set multi shadow.

Features:

  1. upgrade istio to v1.21.2;
  2. set Mirrors for VirtualService if multi shadow has been set.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


jianmao seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@caozhuozi
Copy link
Contributor

I think the change is quite significant and may not be backward compatible and necessitates additional consideration. The change requires the Seldon users to also upgrade the istio version to >= 1.20. Otherwise, the introduction of the new mirrors field would lead to Istio refusing to create the VirtualService.

To ensure backward compatibility, in my opinion, my suggestion is to introduce a new flag or environment variable that can toggle the new feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants