Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix status code handling #855

Merged
merged 2 commits into from
Sep 13, 2019
Merged

Conversation

dtaniwaki
Copy link
Contributor

All the errors become 400 in the current implementation.

@seldondev
Copy link
Collaborator

Hi @dtaniwaki. Thanks for your PR.

I'm waiting for a SeldonIO member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ukclivecox
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cliveseldon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ukclivecox
Copy link
Contributor

/ok-to-test

@dtaniwaki
Copy link
Contributor Author

How can I check the errors of the CI?

@axsaucedo
Copy link
Contributor

There job seems to not have found enough resources, we'll try to retest

@axsaucedo
Copy link
Contributor

/retest

@axsaucedo
Copy link
Contributor

@dtaniwaki all tests pass :) although there seems to be some merge conflicts

@axsaucedo
Copy link
Contributor

The conflicts were just on imports so I fixed them - you have the approved label so as soon as tests pass the PR should be automatically merged 👍 thank you for your contribution @dtaniwaki !

@seldondev seldondev merged commit ec41863 into SeldonIO:master Sep 13, 2019
@dtaniwaki dtaniwaki deleted the fix-status-code branch September 13, 2019 11:13
@axsaucedo
Copy link
Contributor

PR has been landed - thanks again for your contribution @dtaniwaki !

@dtaniwaki
Copy link
Contributor Author

You’re welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants