Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bypass engine via annotation #945

Merged
merged 5 commits into from
Oct 17, 2019
Merged

Bypass engine via annotation #945

merged 5 commits into from
Oct 17, 2019

Conversation

ukclivecox
Copy link
Contributor

  • Allow direct model API calls for single model scenarios
  • Activated by an annotation in the predictor seldon.io/no-engine: "true"
  • Updates python wrapper to allow direct external API calls

This PR also:

  • Adds some initial BDD tests to operator (Need to include istio CRD)

@ukclivecox
Copy link
Contributor Author

/assign @ryandawsonuk

@axsaucedo
Copy link
Contributor

/cc @ryandawsonuk

@cliveseldon I actually found it quite confusing but it seems that with Prow the command / assign only subscribes them, whilst / cc (and / uncc) is what adds/removes people as reviewers

@axsaucedo
Copy link
Contributor

Wow, the change in the Python client is amazingly simple. Really cool!

@ryandawsonuk
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ryandawsonuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev seldondev merged commit 4accc9b into SeldonIO:master Oct 17, 2019
@ukclivecox ukclivecox deleted the bypass_engine branch February 14, 2020 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants