WIP: Explainer updates #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axsaucedo
reviewed
Mar 5, 2021
| @@ -35,6 +35,16 @@ def create_v2_from_np(arr: np.ndarray, name: str) -> Dict: | |||
| else: | |||
| raise ValueError(f"Unknown numpy type {arr.dtype}") | |||
|
|
|||
| @staticmethod | |||
| def create_v2_from_any(data: Any, name: str) -> Dict: | |||
| b = list(bytes(data, 'utf-8')) | |||
There was a problem hiding this comment.
Does it have to be converted to bytes or would it be ok to just return as an arbitrary dictionary? Is this to ensure it is consistent with grpc proto schema?
There was a problem hiding this comment.
It needs to be bytes I think as its raw data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.