Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated example #95

Merged
merged 8 commits into from
Apr 16, 2021
Merged

Updated example #95

merged 8 commits into from
Apr 16, 2021

Conversation

ukclivecox
Copy link
Contributor

@ukclivecox ukclivecox commented Apr 16, 2021 •
edited
Loading

  • New introduction docs example built around a project structure
  • Ability to pass runtime_options when you create Runtime object
  • Default to V2 Dataplane protocol

RafalSkolasinski
RafalSkolasinski reviewed Apr 16, 2021
View reviewed changes
conda/tempo-examples.yaml Outdated
@@ -16,3 +18,11 @@ dependencies:
- xgboost
- ansible
- openshift
- black==20.8b1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this in environment that is just meant to be used by user to run the examples?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably not - the examples just use pytest

@ukclivecox ukclivecox merged commit 3df8514 into SeldonIO:master Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafalSkolasinski RafalSkolasinski RafalSkolasinski left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ukclivecox @RafalSkolasinski