Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example of multiple nodes on same VM #1485

Merged
merged 2 commits into from
Jan 30, 2022
Merged

Add example of multiple nodes on same VM #1485

merged 2 commits into from
Jan 30, 2022

Conversation

Dan-DeAraujo
Copy link
Contributor

@Dan-DeAraujo Dan-DeAraujo commented Jan 25, 2022

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

It's not clear from the documentation that the container will be listening on a port other than 5555 when the SE_NODE_PORT parameter is provided. This PR adds an example of the case where there are two nodes running on the same machine/VM, and shows the correct port mapping and environment variable configuration

Motivation and Context

This behavior is different than in Selenium3, where the container was always listening on 5555, so the port mapping always pointed there. TBH, I'm not 100% sure if this was an intended change or not... but if not, please let me know and I will close update this PR and open a bug report.
Note that this is also different behavior than the VNC port for the container, which always listens on 5900.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@CLAassistant
Copy link

CLAassistant commented Jan 25, 2022

CLA assistant check
All committers have signed the CLA.

@Dan-DeAraujo Dan-DeAraujo changed the title Add example of mupltiple nodes on same VM Add example of multiple nodes on same VM Jan 25, 2022
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Dan-DeAraujo!

@diemol diemol merged commit 65ea5d2 into SeleniumHQ:trunk Jan 30, 2022
@Dan-DeAraujo Dan-DeAraujo deleted the patch-1 branch November 4, 2022 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants