Add example of multiple nodes on same VM #1485
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
It's not clear from the documentation that the container will be listening on a port other than 5555 when the SE_NODE_PORT parameter is provided. This PR adds an example of the case where there are two nodes running on the same machine/VM, and shows the correct port mapping and environment variable configuration
Motivation and Context
This behavior is different than in Selenium3, where the container was always listening on 5555, so the port mapping always pointed there. TBH, I'm not 100% sure if this was an intended change or not... but if not, please let me know and I will
closeupdate this PR and open a bug report.Note that this is also different behavior than the VNC port for the container, which always listens on 5900.
Types of changes
Checklist