Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing FIREFOX_VERSION from devedition-latest to nightly-latest #1672

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

jamesmortensen
Copy link
Member

fix #1670

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Nightly is the correct FIREFOX_VERSION as devedition-latest is the beta version with extra developer tools baked into it.

Motivation and Context

firefox:dev version should be on the bleeding edge.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jamesmortensen jamesmortensen merged commit 5a3927a into trunk Sep 7, 2022
@jamesmortensen jamesmortensen deleted the issue1670 branch September 7, 2022 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant