Replace x11vnc with tightvnc. #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, I'll plan to take a look at this on Friday. |
|
@phensley Bump |
|
Hey @mtscout6, thanks for the feedback, I'm just getting back to this now. I'll rework this a bit and push another commit. |
|
@phensley Doesn't merge w/o conflicts any more. |
|
Hi, If not, let us know and we can close the PR. |
|
@diemol I no longer have interest in merging. |
|
Thanks for replying @phensley, and apologies for not reacting to this earlier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm running my docker-selenium nodes using tightvnc to record video of browser sessions over the network. I've found it to be more responsive than x11vnc. If there is interest in keeping x11vnc the entry point could be modularized so that either x11vnc or tightvnc could be started, e.g.
VNCSERVER=[x11vnc | tightvnc]