You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for contributing to the Docker-Selenium project! A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Fix: Error setting name in helm release #2006 & #2007
Motivation and Context
After PR #1989, template .fullName was updated in podTemplate. However, it caused a mismatch between selector and the template labels, which caused the helm command gets failed when component set .nameOverride
In part of this PR also contains:
Add workflow to test chart, the first test is used to cover this use case
Workflow trigger events on push, pull request with paths 'charts/selenium-grid/**'
Chart install with multiple values can be appended later under charts/selenium-grid/ci/*-values.yaml. This folder is excluded from package chart production via .helmignore to avoid confusion from the user.
Config for ct action is located user tests/chart-test.yaml
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
It looks like helm/kind-action has a limitation on computing, the workflow helm-chart-test is unstable sometimes due to 0/1 nodes are available: 1 Insufficient cpu(actions/runner-images#7107) when bringing up basic setup 1 hub & 3 nodes together.
In order to make the workflow stable, we will break down and test 1 hub : 1 node at a time, and repeat 3 times for 3 types of browser nodes by creating 3 separate values files under ci/*values.yaml
Changeset 356754d
@diemol, I resolved conflicts. Can you approve workflow runs to check?
In my change has set check-version-increment: false, I think it would resolve failure in another PR.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VietND96
changed the title
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Fix: Error setting name in helm release #2006 & #2007
Motivation and Context
After PR #1989, template
.fullNamewas updated in podTemplate. However, it caused a mismatch betweenselectorand the templatelabels, which caused the helm command gets failed when component set.nameOverrideIn part of this PR also contains:
charts/selenium-grid/ci/*-values.yaml. This folder is excluded from package chart production via.helmignoreto avoid confusion from the user.ctaction is located usertests/chart-test.yamlTypes of changes
Checklist