Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chart): Append subPath to ENV variable SE_NODE_GRID_URL #2053

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

VietND96
Copy link
Member

@VietND96 VietND96 commented Dec 8, 2023

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

feat(chart): Append subPath to ENV variable SE_NODE_GRID_URL

Motivation and Context

When hub.subPath or components.subPath (belong to isolateComponents: true) is set proper value. It would be appended to node ENV variable SE_NODE_GRID_URL accordingly.

For example

isolateComponents: true
components:
  subPath: /selenium

SE_NODE_GRID_URL populated value http://admin:admin@selenium-router.default:4444/selenium

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
@VietND96 VietND96 merged commit 3e19181 into SeleniumHQ:trunk Dec 8, 2023
4 of 6 checks passed
@VietND96 VietND96 deleted the helm-chart branch December 8, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant