Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chart): Remove trailing slash from default subPath value #2076

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

VietND96
Copy link
Member

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

fix(chart): Remove trailing slash from default subPath value

Motivation and Context

While waiting for the upstream fix SeleniumHQ/selenium#13353 is picked up in 4.17.0
Remove the trailing slash from the default chart values.yaml to unblock #2075

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
@VietND96 VietND96 merged commit a1082c2 into SeleniumHQ:trunk Dec 22, 2023
6 checks passed
@VietND96 VietND96 self-assigned this Jan 8, 2024
@VietND96 VietND96 deleted the fix-chart branch January 8, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: VNC viewer issue in Kubernetes with nginx ingress extra / in wss URL
1 participant