Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(nightly): Add build image based on upstream Selenium Nightly #2088

Merged
merged 1 commit into from Jan 10, 2024

Conversation

VietND96
Copy link
Member

@VietND96 VietND96 commented Jan 10, 2024

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

build(nightly): Add build image based on upstream Selenium Nightly

Motivation and Context

Solve #1712

Nightly images are built on top of the Nightly build on the upstream project Selenium with the latest changes on main branch in this repository. The image tag is nightly. This is not recommended to use images in production. It is only for testing purpose.

$ docker run -d -p 4442-4444:4442-4444 --name selenium-hub selenium/hub:nightly

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
@VietND96 VietND96 linked an issue Jan 10, 2024 that may be closed by this pull request
@VietND96 VietND96 requested a review from diemol January 10, 2024 02:42
@VietND96 VietND96 merged commit 6eca337 into SeleniumHQ:trunk Jan 10, 2024
7 checks passed
@VietND96 VietND96 self-assigned this Jan 10, 2024
@VietND96
Copy link
Member Author

@diemol
Copy link
Member

diemol commented Jan 10, 2024

Perfect!

@VietND96 VietND96 deleted the nightly branch January 15, 2024 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🚀 Feature]: add nightly build
2 participants