Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: x11vnc delayed #2119

Merged
merged 1 commit into from Jan 25, 2024
Merged

bug: x11vnc delayed #2119

merged 1 commit into from Jan 25, 2024

Conversation

0xC4N1
Copy link
Contributor

@0xC4N1 0xC4N1 commented Jan 25, 2024

Fixes #2118

Description

This change installs the dependencies used in NodeBase/start-vnc.sh to avoid x11vnc delays.

Motivation and Context

Since #2061 the dependencies are missing due to --no-install-recommends causing x11vnc startup delays.
The packages where tested in a 4.17.0-20240123 container which has been restarted to confirm that the delays are fixed.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@CLAassistant
Copy link

CLAassistant commented Jan 25, 2024

CLA assistant check
All committers have signed the CLA.

@VietND96
Copy link
Member

@0xC4N1, can you please sign the CLA

@VietND96 VietND96 merged commit 01fc206 into SeleniumHQ:trunk Jan 25, 2024
9 checks passed
@VietND96
Copy link
Member

Thank you, @0xC4N1!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: x11vnc delayed
3 participants