Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: non-root user for video recorder #2122

Merged
merged 1 commit into from Jan 31, 2024
Merged

Conversation

VietND96
Copy link
Member

@VietND96 VietND96 commented Jan 31, 2024

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

[馃殌 Feature]: non-root user for selenium/video #2108

Motivation and Context

  • Apply the same implementation non-root user in Base image to the Video recorder image
  • Update video_test with a random user (true)
  • Helm chart: remove runAsUser: 0 (root) from securityContext of videoRecorder

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
@VietND96 VietND96 self-assigned this Jan 31, 2024
@VietND96 VietND96 requested a review from diemol January 31, 2024 04:17
@VietND96 VietND96 linked an issue Jan 31, 2024 that may be closed by this pull request
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thank you!

I remember I wanted to do this during the first implementation but had no time. Thanks!

@VietND96 VietND96 merged commit 153a660 into SeleniumHQ:trunk Jan 31, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[馃殌 Feature]: non-root user for selenium/video
2 participants