Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: video upload supports both docker-compose and helm chart #2131

Merged
merged 3 commits into from Feb 11, 2024

Conversation

VietND96
Copy link
Member

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

feat: video upload supports both docker-compose and helm chart

Motivation and Context

  • The first time video uploader was introduced in feat: video recording with pluggable upload container #1881 as a sidecar container running in Node pod deployed on Kubernetes via Helm chart.
  • After changes for uploader support variant storage vendors in feat(chart): Add RCLONE as default video uploader on Kubernetes #2100. RCLONE is used as default.
  • Instead of having 3 containers in a Node pod, and taking advantage of RCLONE, Now, RCLONE binary is installed to the video recorder image, needed scripts are also added, uploading option will be enabled/disabled via container ENV variables.
  • Docker-compose now can enable the uploading utility in the video recorder container. Added a docker-compose file for example.

Regression:

  • Helm chart still supports configuring the third pluggable container if the default does not support the user's demand
  • The uploading function is disabled by default and no change in the script flow Dynamic Grid, docker run, docker compose.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
After RCLONE is installed and upload scripts is moved to built-in recorder image, by default no need the third sidecar container for uploader.
If not using default RCLONE, user is able to configure for the third container with their settings

Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
@VietND96 VietND96 merged commit b1d36d5 into SeleniumHQ:trunk Feb 11, 2024
9 checks passed
@VietND96 VietND96 deleted the compose-upload branch February 11, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant