fix accessing .Values in templates

[maxmanuylov]

User description

Description

".Values" is incorrectly accessed in some templates (in those, for which the context is not global)

Motivation and Context

Right now browser nodes do not start because startup probe does not work because probe scripts are not mounted to the pod because ".Values.nodeConfigMap.extraScripts" is empty when template is called with non-global context.

Types of changes

• Bug fix (non-breaking change which fixes an issue)

---

Type

bug_fix

---

Description

• Fixed an issue where .Values was incorrectly accessed in autoscaling and video recorder configurations, causing browser nodes not to start.
• Ensured autoscaling spec template correctly merges configurations and handles triggers by using global context.
• Updated video recorder and uploader configurations to reference global .Values for consistency and correctness.
• Corrected configurations related to image pull secrets, node selector, and volumes to properly use global .Values.

---

Changes walkthrough

Relevant files

Bug fix

_helpers.tpl Fix Incorrect Access to .Values in Autoscaling and Video Recorder Configurations charts/selenium-grid/templates/_helpers.tpl Fixed incorrect access to .Values in autoscaling and video recorder configurations by ensuring the context is global using $. Adjusted autoscaling spec template to correctly merge configurations and handle triggers. Updated video recorder and uploader configurations to use global context for .Values. Corrected image pull secrets, node selector, and volumes configuration to properly reference global .Values. +35/-35

---

✨ PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[CLAassistant]

All committers have signed the CLA.

[codiumai-pr-agent-pro]

PR Description updated to latest commit (fb42ab2)

• Copy walkthrough table to "Files Changed" Tab

[codiumai-pr-agent-pro]

PR Review

⏱️ Estimated effort to review [1-5]	2, because the changes are mostly about ensuring the correct scope is used for accessing values in Helm templates. The modifications are straightforward and follow a consistent pattern across the file.
🧪 Relevant tests	No
🔍 Possible issues	Context Scope: Ensure that the switch from local to global context ($) does not inadvertently affect other parts of the template where local context might be necessary.
	Hardcoded Values: The use of hardcoded values (e.g., triggerIndex: '{{ default $.Values.autoscaling.scaledOptions.minReplicaCount (.node.scaledOptions).minReplicaCount }}') could be less flexible for some configurations. Consider making these values more configurable if needed.
🔒 Security concerns	No

---

✨ Review tool usage guide:

---

Overview:
The review tool scans the PR code changes, and generates a PR review which includes several types of feedbacks, such as possible PR issues, security threats and relevant test in the PR. More feedbacks can be added by configuring the tool.

The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.

• When commenting, to edit configurations related to the review tool (pr_reviewer section), use the following template:

/review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=...

• With a configuration file, use the following template:

[pr_reviewer]
some_config1=...
some_config2=...

See the review usage page for a comprehensive guide on using this tool.

[codiumai-pr-agent-pro]

PR Code Suggestions

Category	Suggestions
Best practice	Convert $spec back to a dictionary after toYaml to ensure correct merging. To ensure that the mergeOverwrite function correctly merges the dictionaries, it's recommended to explicitly convert the $spec variable back to a dictionary after the toYaml operation. This ensures that the mergeOverwrite function operates on dictionaries rather than strings, which is its intended use. charts/selenium-grid/templates/_helpers.tpl [137] -{{- $spec = mergeOverwrite ($spec | fromYaml) . | toYaml -}} +{{- $spec = mergeOverwrite ($spec | fromYaml) . | toYaml | fromYaml -}}
Possible issue	Validate existence of nested keys before access to avoid runtime errors. Consider validating the existence of $.Values.autoscaling.scaledOptions.triggers before attempting to access it to avoid potential runtime errors in case the triggers key is not defined in the values file. charts/selenium-grid/templates/_helpers.tpl [163] -{{- if not $.Values.autoscaling.scaledOptions.triggers }} +{{- if and $.Values.autoscaling.scaledOptions (not $.Values.autoscaling.scaledOptions.triggers) }}
Maintainability	Use a helper template for constructing image names for maintainability. For better maintainability and readability, consider using a helper template for constructing image names, which can be reused across different parts of the chart. charts/selenium-grid/templates/_helpers.tpl [213] -image: {{ printf "%s/%s:%s" $imageRegistry .node.imageName $imageTag }} +image: {{ include "seleniumGrid.constructImageName" (dict "registry" $imageRegistry "name" .node.imageName "tag" $imageTag) }}
Enhancement	Validate uploader configuration to prevent configuration errors. To ensure the video recorder's uploader component is correctly configured, validate that both $.Values.videoRecorder.uploader.enabled and $.Values.videoRecorder.uploader.name are set. This prevents the creation of an uploader container without a specified name, which could lead to configuration errors. charts/selenium-grid/templates/_helpers.tpl [397] {{- if and $.Values.videoRecorder.uploader.enabled (not (empty $.Values.videoRecorder.uploader.name)) }} + # Ensure uploader configuration is valid here +{{- else }} + # Handle invalid uploader configuration +{{- end }}
Security	Define a restrictive securityContext for containers to enhance security. To improve the security and restrict the permissions of the video recorder and uploader containers, consider defining a more restrictive securityContext. This can help in minimizing potential security risks. charts/selenium-grid/templates/_helpers.tpl [386] -securityContext: {{- toYaml . | nindent 10 }} +securityContext: + runAsUser: 1000 + runAsNonRoot: true + readOnlyRootFilesystem: true + capabilities: + drop: + - ALL

---

✨ Improve tool usage guide:

---

Overview:
The improve tool scans the PR code changes, and automatically generates suggestions for improving the PR code. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on a PR.

• When commenting, to edit configurations related to the improve tool (pr_code_suggestions section), use the following template:

/improve --pr_code_suggestions.some_config1=... --pr_code_suggestions.some_config2=...

• With a configuration file, use the following template:

[pr_code_suggestions]
some_config1=...
some_config2=...

See the improve usage page for a comprehensive guide on using this tool.

[VietND96]

@maxmanuylov, thank you for your interest in the chart and for providing a valuable fix!