Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Firefox developer edition #679

Merged
merged 1 commit into from Feb 26, 2018
Merged

Build Firefox developer edition #679

merged 1 commit into from Feb 26, 2018

Conversation

l0b0
Copy link

@l0b0 l0b0 commented Feb 25, 2018

Resolves #536.

@diemol
Copy link
Member

diemol commented Feb 26, 2018

Hi @l0b0,

Thanks for this PR!

Nevertheless, we would not push a new image with Firefox Developer Edition to Docker Hub. The current images try to be as generic as possible, and this is not a common use case. The idea is that it should work in the same way as the Nightly or Chrome Beta, in the sense that if anyone needs that image, s/he should build it on her/his own.

Having said that, this is the part that we would accept. Could you please modify the PR so it only includes that? Thanks!

@ddavison
Copy link
Member

LGTM 👍

@diemol
Copy link
Member

diemol commented Feb 26, 2018

Ah cool, I triggered again the build last night and it worked. Let's merge.
Thanks @l0b0

@diemol diemol merged commit 80d85ef into SeleniumHQ:master Feb 26, 2018
l0b0 pushed a commit to l0b0/insecure-links-highlighter that referenced this pull request Feb 27, 2018
@denishowew
Copy link

An image for Firefox developer edition would let us test our browser extension without having to go through Mozilla's slow and flaky signing process every time. Dev edition is the only way to load unsigned extensions.

@diemol
Copy link
Member

diemol commented Sep 10, 2020

As mentioned above, we want to offer generic images, and aside from that, we do not have the capacity to maintain an image with a browser that has not been released yet. If issues are raised to its behavior, only the time spent to triage them is already an overhead for us. That is why we offer instructions for the community on how to do it, and with that unblock themselves, anyone can set a CI env and build that image on a daily basis if wished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants