-
Notifications
You must be signed in to change notification settings - Fork 164
Added instructions for adding executables to your PATH #98
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also format so that no lines have more than ~72 characters per line.
<h4>On OS X / Linux</h4> | ||
<ul> | ||
<li>In a terminal: <pre><code>export PATH=$PATH:/path/to/dir >> ~/.profile</code></pre></li> | ||
</ul> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use <pre>
.
Also this only works when using the bash shell.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a better option we could recommend which works for all shells? Or could I get away with spelling out this way only works with bash?
<h4>On Windows</h4> | ||
<ul> | ||
<li>Create a directory to place the executables in, like <em>C:\WebDriver\bin</em></li> | ||
<li>Open a new cmd window as administrator and the run the following command to permanently add the directory to your path for all users on your machine:<pre><code>setx /m path "%path%;C:\WebDriver\bin\"</code></pre></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/cmd window/command prompt/
Also drop the <code>
.
<ul> | ||
<li>Create a directory to place the executables in, like <em>C:\WebDriver\bin</em></li> | ||
<li>Open a new cmd window as administrator and the run the following command to permanently add the directory to your path for all users on your machine:<pre><code>setx /m path "%path%;C:\WebDriver\bin\"</code></pre></li> | ||
<li>Close all cmd windows and open a new one. You can test by trying to run one of the binaries - e.g: <pre><code>chromedriver -v</code></pre>If that worked, you should be all set!</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Again, s/cmd windows/command prompts/.
- Drop
<code>
. - The last sentence doesn’t make sense. Please fix grammar.
@@ -66,6 +66,19 @@ | |||
This section explains the basic requirements | |||
for getting you started with the different browsers. | |||
|
|||
<h3>Adding Executables to your PATH</h3> | |||
<p>Most drivers require an extra executable for Selenium to communicate with the browser. You can manually specify where the executable lives before starting WebDriver, but this can make your tests less portable, as the executables will need to be in the same place on every machine, or included within your test code repository. | |||
<p>By adding a folder containing WebDriver's binaries to your system's path, Selenium will be able to locate the additional binaries without requiring your test code to locate the exact location of the driver.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double full stop.
Cheers for the review @andreastt - I've made some changes as requested. |
Thanks! |
No description provided.