Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[🚀 Feature]: Update extensions in bindings to the new common ones. #10266

Closed
titusfortner opened this issue Jan 19, 2022 · 1 comment
Closed

[🚀 Feature]: Update extensions in bindings to the new common ones. #10266

titusfortner opened this issue Jan 19, 2022 · 1 comment
Labels
C-dotnet C-rb I-enhancement

Comments

@titusfortner
Copy link
Member

Feature and motivation

@nickgaya added extensions in common directory https://github.com/seleniumhq/selenium/tree/trunk/common/extensions

Would be nice for all languages to update to use these extensions in their test code.
Usage example here: #10216

Usage example

add to bazel file as data:

data = TEST_DATA + [
    "//common/extensions",
    ...

then can reference it from main directory:

/common/extensions/webextensions-selenium-example.crx
pujagani added a commit to pujagani/selenium that referenced this issue Feb 25, 2022
@pujagani
[java] Update extension in the tests to use the common extensions
4036055 
Related to SeleniumHQ#10266
pujagani added a commit to pujagani/selenium that referenced this issue Feb 25, 2022
@pujagani
[java] Update extension in the tests to use the common extensions
1c5108f 
Related to SeleniumHQ#10266
@pujagani pujagani mentioned this issue Feb 25, 2022
Merged
8 tasks
@diemol diemol removed the C-java label Feb 25, 2022
diemol pushed a commit that referenced this issue Feb 25, 2022
@pujagani
[java] Update extension in the tests to use the common extensions (#1…
00f7655 
…0398)

Related to #10266

Co-authored-by: Diego Molina <diemol@users.noreply.github.com>

[skip ci]
SinghHrmn added a commit to SinghHrmn/selenium that referenced this issue Mar 25, 2022
@SinghHrmn
[py] Update extension in the tests to use the common extensions
1f06bb3 
Removes C-py tag from SeleniumHQ#10266
@SinghHrmn SinghHrmn mentioned this issue Mar 25, 2022
Merged
8 tasks
SinghHrmn added a commit to SinghHrmn/selenium that referenced this issue Mar 27, 2022
@SinghHrmn
[py] Update extension in the tests to use the common extensions
9811802 
Removes C-py tag from SeleniumHQ#10266
AutomatedTester pushed a commit that referenced this issue Apr 6, 2022
@SinghHrmn @pujagani
[py] Update extension in the tests to use the common extensions (#10478)
dad6f8c 
* [py] Update extension in the tests to use the common extensions

Removes C-py tag from #10266

* fix: updated py BUILD.bazel merge issue

Co-authored-by: Puja Jagani <puja.jagani93@gmail.com>
@diemol diemol removed the C-py label Jun 8, 2022
elgatov pushed a commit to elgatov/selenium that referenced this issue Jun 27, 2022
@pujagani @elgatov
[java] Update extension in the tests to use the common extensions (Se…
8cbc84c 
…leniumHQ#10398)

Related to SeleniumHQ#10266

Co-authored-by: Diego Molina <diemol@users.noreply.github.com>

[skip ci]
elgatov pushed a commit to elgatov/selenium that referenced this issue Jun 27, 2022
@SinghHrmn @pujagani @elgatov
[py] Update extension in the tests to use the common extensions (Sele…
704b5a4 
…niumHQ#10478)

* [py] Update extension in the tests to use the common extensions

Removes C-py tag from SeleniumHQ#10266

* fix: updated py BUILD.bazel merge issue

Co-authored-by: Puja Jagani <puja.jagani93@gmail.com>
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
C-dotnet C-rb I-enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@titusfortner @diemol