-
-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
node: Add support for installing unpacked addons at runtime in Firefox webdriver #10216
Conversation
Codecov Report
@@ Coverage Diff @@
## trunk #10216 +/- ##
==========================================
- Coverage 45.19% 44.92% -0.27%
==========================================
Files 85 85
Lines 5572 5473 -99
Branches 269 269
==========================================
- Hits 2518 2459 -59
+ Misses 2785 2745 -40
Partials 269 269
Continue to review full report at Codecov.
|
2fd7e2d
to
19af9f3
Compare
Kudos, SonarCloud Quality Gate passed! |
Wow, this is great! Thank you for the extra effort you put in to make the extensions available in common. Now I actually have to re-implement things in the other languages to follow this approach. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @nickgaya.
If this does what I think it does (being able to install unsigned extensions locally without having to build my own Selenium for Firefox Devedition) that would be fantastic! Is that right? If so, is there some documentation on how to use it, or should it just work in the same way as in Devedition? |
It should already work if you zip the directory yourself. This PR lets you just pass in the path and Selenium will zip and send for you. You can see examples here — https://github.com/SeleniumHQ/selenium/blob/trunk/javascript/node/selenium-webdriver/test/firefox_test.js#L222 |
…x webdriver (SeleniumHQ#10216) * node: Add support for installing unpacked addons at runtime in Firefox webdriver * Move example webextension files to //common/extensions
Description
Add support for installing an extension from a directory in the Node.js Firefox WebDriver client.
The implementation checks if the addon path provided is a directory and, if so, creates a zip archive of the directory contents to send to geckodriver.
Motivation and Context
This implements #8357 for node. The same approach can be used for other language bindings.
The approach of creating an ad-hoc zip archive for a local directory was suggested here: #9494 (comment)
Types of changes
Checklist