[🐛 Bug]: Selenium manager doesn't work in paths that contain spaces

[cfarmerga]

What happened?

I am using Windows 11 and have a simple js script that tries to build a driver using selenium manager. I see that it works fine when I have the script in a path which contains no spaces, but it fails when spaces exist in the path with this error:

c:\dev\selenium path with space>node simple.js                                                                                                                                                   
 The ChromeDriver could not be found on the current PATH, trying Selenium Manager                                                                                                                
'c:\dev\selenium' is not recognized as an internal or external command,                                                                                                                          
operable program or batch file.                                                                                                                                                                  
Unable to obtain driver using Selenium Manager: Error: Error executing command with c:\dev\selenium path with space\node_modules\selenium-webdriver\bin\windows\selenium-manager.exe,--browser,ch
rome                                                                                                                                                                                             
'c:\dev\selenium' is not recognized as an internal or external command,                                                                                                                          
operable program or batch file.                                                                                                                                                                  
                                                                                                                                                                                                 
c:\dev\selenium path with space\node_modules\selenium-webdriver\chrome.js:175                                                                                                                    
      throw Error(                                                                                                                                                                               
            ^        

I see that the cause seems to be the code in selenium-webdriver/common/seleniumManager.js (line 76), where the driverLocation function tries to use the result of getBinary() directly in execSync. It seems like this path should be quoted before being passed to execSync.

Also posted to https://stackoverflow.com/questions/75438848/selenium-builder-failing-with-spaces-in-path

How can we reproduce the issue?

package.json:
{
  "type": "commonjs",
  "dependencies": {
    "selenium-webdriver": "4.8.0"
  }
}


Here's the relevant code:

const { Builder, Browser } = require("selenium-webdriver");

(async function example() {
  const driver = await new Builder().forBrowser(Browser.CHROME).build();
  driver.get("https://stackoverflow.com");
})();

Relevant log output

c:\dev\selenium path with space>node simple.js                                                                                                                                                   
 The ChromeDriver could not be found on the current PATH, trying Selenium Manager                                                                                                                
'c:\dev\selenium' is not recognized as an internal or external command,                                                                                                                          
operable program or batch file.                                                                                                                                                                  
Unable to obtain driver using Selenium Manager: Error: Error executing command with c:\dev\selenium path with space\node_modules\selenium-webdriver\bin\windows\selenium-manager.exe,--browser,ch
rome                                                                                                                                                                                             
'c:\dev\selenium' is not recognized as an internal or external command,                                                                                                                          
operable program or batch file.

Operating System

Windows 11

Selenium version

javascript 4.8.0

What are the browser(s) and version(s) where you see this issue?

Chrome

What are the browser driver(s) and version(s) where you see this issue?

Any

Are you using Selenium Grid?

No response

[github-actions]

@cfarmerga, thank you for creating this issue. We will troubleshoot it as soon as we can.

---

Info for maintainers

Triage this issue by using labels.

If information is missing, add a helpful comment and then I-issue-template label.

If the issue is a question, add the I-question label.

If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.

If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C), add the applicable G-* label, and it will provide the correct link and auto-close the issue.

After troubleshooting the issue, please add the R-awaiting answer label.

Thank you!

[surajverma255]

Meanwhile, we can eliminate the spaces with replaceAll() to make it understand the path.

[atrnh]

Just in case it helps this get triaged sooner, here's the problematic line of code:

selenium/javascript/node/selenium-webdriver/common/seleniumManager.js

Line 76 in a9fd3cf

output = JSON.parse(execSync(args.join(' ')).toString())

Since execSync doesn't handle escaping shell metacharacters, I'm guessing we want to use spawnSync here instead? 🤔

We use Selenium in the classroom and this bug has been causing issues for our students. If no one has a chance to take a look at this, I might offer up a PR 😅

[titusfortner]

@atrnh yes, we would love a PR! thank you.

[atrnh]

@atrnh yes, we would love a PR! thank you.

Thanks for the response @titusfortner! I've submitted a PR 😊

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.