[js] Replace execSync with spawnSync in seleniumManager.js (#11649)
#11873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since execSync does not escape shell metacharacters, attempting to execute a command with a space in it will fail. This is the case when the path to selenium-manager contains a space. This commit replaces execSync with spawnSync, which does escape shell metacharacters. Fixes SeleniumHQ#11649
|
|
diemol
approved these changes
Apr 20, 2023
There was a problem hiding this comment.
Thank you, @atrnh!
I made some refinements because I got a few errors when I tried it locally. But it is indeed a good idea to use spawnSync instead of execSync, seems that command and arguments, plus return streams are easier to handle.
oriongonza
pushed a commit
to oriongonza/selenium
that referenced
this pull request
Apr 24, 2023
…eniumHQ#11649) (SeleniumHQ#11873) * replace execSync with spawnSync in seleniumManager.js Since execSync does not escape shell metacharacters, attempting to execute a command with a space in it will fail. This is the case when the path to selenium-manager contains a space. This commit replaces execSync with spawnSync, which does escape shell metacharacters. Fixes SeleniumHQ#11649 * [javascript] Refine usage of spawnSync --------- Co-authored-by: Sri Harsha <12621691+harsha509@users.noreply.github.com> Co-authored-by: Diego Molina <diemol@users.noreply.github.com> Co-authored-by: Diego Molina <diemol@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaced
execSyncwithspawnSyncinjavascript/node/selenium-webdriver/common/seleniumManager.js.I also had to change the way errors are handled a bit, because
spawnSyncdoesn't raise exceptions. Instead, it returns an object with anerrorproperty. I was able to retain the existing error-handling constructs, but it feels a bit indirect due to howspawnSyncworks. Not sure if this is a big deal or not!Motivation and Context
Since
execSyncdoes not escape shell metacharacters, attempting to execute a command with a space in it will fail. This is the case described in #11649, when the path toselenium-managercontains a space. This commit replacesexecSyncwithspawnSync, which does escape shell metacharacters.Types of changes
Checklist