Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please accept this documentation update #1

Closed
wants to merge 2 commits into from

Conversation

krosenvold
Copy link
Member

I have signed the CLA ;)

@lukeis
Copy link
Member

lukeis commented Jan 15, 2013

fixed with d835b9b

(annoying to not see the sync happen and thus github sees two commits here)

Also do you think we should follow the maven git convention and 'alter' the commit message as I did?

@lukeis lukeis closed this Jan 15, 2013
@lukeis
Copy link
Member

lukeis commented Jan 15, 2013

Looks like I changed the Author too, so i guess I shouldn't do that :)

@krosenvold
Copy link
Member Author

I think we specifically want to avoid changing the author. I suggested
using --signoff --amend which is "simple".

Kristian

2013/1/15 Luke Inman-Semerau notifications@github.com

Looks like I changed the Author too, so i guess I shouldn't do that :)


Reply to this email directly or view it on GitHubhttps://github.com//pull/1#issuecomment-12256869.

@lukeis
Copy link
Member

lukeis commented Jan 15, 2013

Yep, makes sense. no beer for me :)

On Tue, Jan 15, 2013 at 12:36 AM, Kristian Rosenvold <
notifications@github.com> wrote:

I think we specifically want to avoid changing the author. I suggested
using --signoff --amend which is "simple".

Kristian

2013/1/15 Luke Inman-Semerau notifications@github.com

Looks like I changed the Author too, so i guess I shouldn't do that :)


Reply to this email directly or view it on GitHub<
https://github.com/SeleniumHQ/selenium/pull/1#issuecomment-12256869>.


Reply to this email directly or view it on GitHubhttps://github.com//pull/1#issuecomment-12257812.

@detro
Copy link
Contributor

detro commented Jan 15, 2013

So, this is totally bidirectional :)

@lukeis
Copy link
Member

lukeis commented Jan 15, 2013

Ivan, not how we intend to use it (as in, please make sure you read
Kristian's emails on the dev list). No direct pushes to github (no using
the github gui to 'merge' a pull request).

On Tue, Jan 15, 2013 at 12:40 AM, Ivan De Marino
notifications@github.comwrote:

So, this is totally bidirectional :)


Reply to this email directly or view it on GitHubhttps://github.com//pull/1#issuecomment-12257902.

@ddavison ddavison mentioned this pull request Oct 24, 2015
michaelpreston added a commit to michaelpreston/selenium that referenced this pull request Feb 7, 2020
Read Firefox Extension ID from appropriate location in manifest.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants