Java: Support for sending firefox addon directory as temporary in remote sessions #10566
Conversation
Codecov Report
@@ Coverage Diff @@
## trunk #10566 +/- ##
=======================================
Coverage 45.02% 45.02%
=======================================
Files 85 85
Lines 5508 5508
Branches 268 268
=======================================
Hits 2480 2480
Misses 2760 2760
Partials 268 268 Continue to review full report at Codecov.
|
| import java.io.IOException; | ||
| import java.nio.file.Files; | ||
| import java.nio.file.Path; | ||
| import java.nio.file.*; |
There was a problem hiding this comment.
IntelliJ tends to do this by default when optimizing imports. But it is good practice to avoid importing entire package.
There was a problem hiding this comment.
Alright, I'll correct that.
| return FileVisitResult.CONTINUE; | ||
| } | ||
| }); | ||
| zos.close(); |
There was a problem hiding this comment.
Could this be done in a Try with Resources block?
Maybe we can extract those lines for the unzipping into another method so it looks more readable.
There was a problem hiding this comment.
Incorporated the changes. Please check to verify and resolve :)
| if (Files.isDirectory(path)) { | ||
| Path extZip = Paths.get(path.getFileName().toString()+".zip"); | ||
| ZipOutputStream zos = new ZipOutputStream(new FileOutputStream(extZip.toFile())); | ||
| Files.walkFileTree(path, new SimpleFileVisitor<Path>() { |
There was a problem hiding this comment.
It should be fine if Path is not passed explicitly.
There was a problem hiding this comment.
Removing Path is breaking the code. I'll look into it further.
|
SonarCloud Quality Gate failed. |
Description
Modified the
installExtension()to send firefox addon directory as temporary in remote session.Motivation and Context
Types of changes
Checklist