Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ruby] Support for sending firefox addon directory as temporary in remote #10937

Closed
wants to merge 1 commit into from
Closed

[ruby] Support for sending firefox addon directory as temporary in remote #10937

wants to merge 1 commit into from

Conversation

TamsilAmani
Copy link
Contributor

Description

Modified the install_addon() to send firefox addon directory as temporary in remote session.

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

luke-hill
luke-hill approved these changes Aug 12, 2022
View reviewed changes
Copy link
Contributor

@luke-hill luke-hill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit. Although no idea why with the specs there doesn't seem to be an assertion - Although I can see it's the same as the other ones.

@titusfortner titusfortner self-assigned this Sep 4, 2022
@titusfortner
Copy link
Member

Merged here: ba0a025
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p0deje p0deje p0deje approved these changes

@luke-hill luke-hill luke-hill approved these changes

Assignees

@titusfortner titusfortner

Labels
C-rb
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TamsilAmani @titusfortner @p0deje @luke-hill